Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serial over BLE #4957

Merged
merged 4 commits into from
Jul 2, 2021
Merged

Add serial over BLE #4957

merged 4 commits into from
Jul 2, 2021

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Jul 1, 2021

Also fixes 0-length writes meant to truncate a file.

@tannewt tannewt added this to the 7.0.0 milestone Jul 1, 2021
@tannewt tannewt requested a review from dhalbert July 1, 2021 19:54
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good!

I am not sure how to test this. I loaded it on a Feather '840, and didn't see it advertising in the Bluefruit app or in the Web Bluetooth Dashboard.

@dhalbert dhalbert merged commit c7ffc2c into adafruit:main Jul 2, 2021
@tannewt
Copy link
Member Author

tannewt commented Jul 2, 2021

Boards with USB and BLE won't advertise unless they've got bonding info stored. If not, you need to press reset when the status led blinks fast and blue. That'll reset and then publicly advertise. The tx power is -40 so it needs to be close to the other device at that point too. Once it's connected, it goes back to 0 tx power.

This was referenced Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants