Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adafruit Macropad RP2040: Fix SPI definition #4966

Merged
merged 1 commit into from
Jul 6, 2021
Merged

Adafruit Macropad RP2040: Fix SPI definition #4966

merged 1 commit into from
Jul 6, 2021

Conversation

dgriswo
Copy link

@dgriswo dgriswo commented Jul 6, 2021

Fixes #4965

@microdev1 microdev1 added board New board or update to a single board rp2 Raspberry Pi RP2 Micros labels Jul 6, 2021
@microdev1 microdev1 self-requested a review July 6, 2021 06:56
microdev1
microdev1 approved these changes Jul 6, 2021
View reviewed changes
Copy link
Collaborator

@microdev1 microdev1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dgriswo Thanks for spotting and fixing this issue. :)

@microdev1 microdev1 changed the title fix spi definition Adafruit Macropad RP2040: Fix SPI definition Jul 6, 2021
@microdev1 microdev1 merged commit 23baa02 into adafruit:main Jul 6, 2021
@ladyada
Copy link
Member

ladyada commented Jul 6, 2021

woops - good catch 😅

@dgriswo
Copy link
Author

dgriswo commented Jul 6, 2021

@ladyada, a huge shout-out to @tannewt for the Friday Deep Dives. I'm not a C programmer and a marginal Python programmer, sometimes knowing where to look and how things work is half the battle. 😉

@tannewt
Copy link
Member

tannewt commented Jul 8, 2021

You are a C programmer now! :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@microdev1 microdev1 microdev1 approved these changes

Assignees
No one assigned
Labels
board New board or update to a single board rp2 Raspberry Pi RP2 Micros
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Macropad RP2040 locks up using board.SPI()
4 participants
@dgriswo @ladyada @tannewt @microdev1