Rp2040 audio fixes; disallow ctrl-C interrupts of SPI and PIO. #4974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Check for correct error values from dma_claim_unused_channel. 2. Introduce a .stereo flag for simplicity. 3. Clarify PWM carrier frequency choice. 4. Start introducing quiescent audio value. Still need to ramp up/down. 5. Redo audio stop logic a bit. 6. Fix (unrelated) displayio dependency things. There is still an interference problem between other DMA users and audio. Still debugging this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some but not all RP2040 audio issues, and fixes MacroPad display issues.
There are a several DMA cleanups. Ctrl-C interrupts of SPI and PIO transactions are also disallowed. SPI ctrl-C interrupts are not allowed on other ports. Allowing ctrl-C can cause bad data/commands to be sent to things like displays.
Tested by @kattni on a MacroPad. Prevents display mess-ups that rendered the display unusable.
I know there is still some underlying DMA problem, and am continuing to work on that.