Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect subscription in usb_hid.Device constructor #5214

Merged
merged 1 commit into from Aug 24, 2021

Conversation

dhalbert
Copy link
Collaborator

@dhalbert dhalbert commented Aug 24, 2021

@fasteddy516 found that the new usb_hid.Device constructor did not work . I was incorrectly subscripting the C arrays instead of the input arg sequences.

Tested by @fasteddy516.

Any reviewer is fine.

@microdev1 microdev1 changed the title ../../shared-bindings/usb_hid/Device.c Fix incorrect subscription in usb_hid.Device constructor Aug 24, 2021
Copy link
Collaborator

@microdev1 microdev1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@microdev1 microdev1 merged commit da320c3 into adafruit:main Aug 24, 2021
@dhalbert dhalbert deleted the usb-hid-device-args-fix branch August 24, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No longer able to create custom USB HID devices.
3 participants