Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update stage library to use keypad module on pygamer and pybadge #5264

Merged
merged 1 commit into from Aug 30, 2021
Merged

Update stage library to use keypad module on pygamer and pybadge #5264

merged 1 commit into from Aug 30, 2021

Conversation

deshipu
Copy link

@deshipu deshipu commented Aug 29, 2021

No description provided.

@cwalther
Copy link

While we’re updating stage, have you taken a look at python-ugame/circuitpython-stage#14?

@deshipu
Copy link
Author

deshipu commented Aug 29, 2021

Ouch, I missed it, even though I now have an e-mail filter specially for this. I guess I will need to make that change to all three files now.

@cwalther
Copy link

Possible – I don’t have a PyBadge or PyGamer so I didn’t check what keys they have and how they are handled.

@deshipu
Copy link
Author

deshipu commented Aug 29, 2021

Updated now to include @cwalther's fix.

microdev1
microdev1 approved these changes Aug 30, 2021
View reviewed changes
Copy link
Collaborator

@microdev1 microdev1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @deshipu.

@microdev1 microdev1 merged commit 156dfad into adafruit:main Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@microdev1 microdev1 microdev1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@deshipu @cwalther @microdev1