changing MICROPY_HW_BOARD_NAME from Dongle to DK #5441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microdev1
approved these changes
Oct 8, 2021
jepler
pushed a commit
to jepler/circuitpython
that referenced
this pull request
Apr 30, 2022
See issue adafruit#5441. This issue is now reproducible on the Arduino Portenta H747, QSPI flash PN MX25L12833F.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was creating a new nRF52833 board, I saw that the nRF52833 DK (PCA10100) MICROPY_HW_BOARD_NAME is incorrectly defined as a Dongle and not a DK.
Both the CircuitPython Org and Nordic Semiconductor sites indicate DK (for development kit)