SAME54: Use best optimization level #5579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's likely that this is a relic of my early testing.
|
I think the |
dhalbert
reviewed
Nov 16, 2021
There was a problem hiding this comment.
I would suggest that we not do this. #3190 found significant performance improvements with -O2. On SAME54 right now, we have plenty of flash, so let's not do this unless necessary. It's too bad the SAMx51 builds are filling up enough to have to go back to -Os, but that's the price of features :)
|
Closing based on my review, but can revisit. |
|
Do we want to ditch the "no inline" flag though? |
Trying that. |
dhalbert
approved these changes
Nov 16, 2021
dhalbert
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's likely that this is a relic of my early testing.