Update protomatter & re-enable rgbmatrix on esp32s2 #5744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.. not enabled on s3 & c3 as I did not test there.
microdev1
reviewed
Dec 17, 2021
There was a problem hiding this comment.
Would you like to enable rgbmatrix on C3 & S3 as well, since main branch is being tagged as alpha and this will encourage more people to test rgbmatrix as it is easier to just load a pre-built firmware.
One more thing, not necessary for it to be a part of this PR, there is a new commit available for esp-idf on release/v4.4 branch.
tannewt
approved these changes
Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.. not enabled on s3 & c3 as I did not test there.