Refactor pin reset on ESP #5894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to blanket never reset flash and USB pins. It also allows us to set a custom state after reset. The first case is for the double tap reset that needs to be pulled low. Fixes micropython#5893
|
Tested on feather esp32s2 -- works! Thank you! |
dhalbert
requested changes
Jan 20, 2022
There was a problem hiding this comment.
Also verified that both .uf2 and .bin on QT Py ESP32-S2 and Metro ESP32-S2 work. S3 and C3 builds are not working:
common-hal/microcontroller/Pin.c:54:9: error: "CONFIG_IDF_TARGET_ESP32S2" is not defined, evaluates to 0 [-Werror=undef]
#if CONFIG_IDF_TARGET_ESP32S2 || CONFIG_IDF_TARGET_ESP32S3
^~~~~~~~~~~~~~~~~~~~~~~~~
common-hal/microcontroller/Pin.c:54:38: error: "CONFIG_IDF_TARGET_ESP32S3" is not defined, evaluates to 0 [-Werror=undef]
#if CONFIG_IDF_TARGET_ESP32S2 || CONFIG_IDF_TARGET_ESP32S3
dhalbert
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to blanket never reset flash and USB pins. It
also allows us to set a custom state after reset. The first case
is for the double tap reset that needs to be pulled low.
Fixes #5893