Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crc32() code moved into binascii #5969

Merged
merged 3 commits into from Feb 2, 2022
Merged

crc32() code moved into binascii #5969

merged 3 commits into from Feb 2, 2022

Conversation

Life-Imaging-Services
Copy link

Moved the code for crc32() from uzlib into modubinascii as suggested by @dhalbert

dhalbert
dhalbert reviewed Feb 2, 2022
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested crc32 on a Metro M4, and it gets the same result as CPython. Excellent, thanks.

Some builds are failing due to size. I will do some squeezing and push some commits to fix those.

@bludin
Copy link

bludin commented Feb 2, 2022

Some builds are failing due to size. I will do some squeezing and push some commits to fix those.
Fantastic. Thanks!

@dhalbert dhalbert mentioned this pull request Feb 2, 2022
Merged
dhalbert
dhalbert approved these changes Feb 2, 2022
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single build problem was fixed. All done. Thanks again!

@dhalbert dhalbert merged commit 0129735 into adafruit:main Feb 2, 2022
@dhalbert dhalbert mentioned this pull request Feb 18, 2022
Closed
@Neradoc Neradoc mentioned this pull request Mar 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Life-Imaging-Services @bludin @dhalbert