fix #6015: rainbowio error for input > 255.0 < 256.0 #6016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
todbot
changed the title
dhalbert
requested changes
Feb 11, 2022
|
Doh, I would've totally used What's the process for doing tiny cleanup work like this? Another PR? |
This MIN() is provided by py/misc.h iirc. It isn't a C thing.
Yup, another PR is welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Of the two fix options described in #6015, this seems like the more-compatible fix. It guards against the overflow that was happening but doesn't change the method signature. (Which would break all existing code that is sending a float, something I do a lot with stuff like
colorwheel( time.monotonic() * 20 )