Fix qstr error #6047

jepler · 2022-02-17T14:41:19Z

Dan noticed that builds were printing a scary message like

../../supervisor/shared/translate.c:90:10: error: "compress_max_length_bits" is not defined, evaluates to 0 [-Werror=undef]
   90 |     #if (compress_max_length_bits <= 8)
      |          ^~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
Command '['arm-none-eabi-gcc', '-E', '-DNO_QSTR', ..., '../supervisor/shared/translate.c']' returned non-zero exit status 1.
make: *** [../../py/mkrules.mk:100: build-adafruit_feather_rp2040/genhdr/qstr.split] Error 1

but continuing, apparently, just fine. This two part PR:

makes the scary message be followed by an actual error that stops make
fixes the original problem, which was harmless but wouldn't have been allowed to creep in if not for the first problem

Due to a number of problems, an error calling the preprocessor wasn't making the whole genlast process fail. Now, after an execption during preprocess is printed, it is re-raised. Then, by actually collating the results of executor.map, the exception will be raised in the main thread context. Any CalledProcessError is simply converted to a nonzero exit status.

dhalbert

Thank you! Builds are working.

jepler added 2 commits February 17, 2022 08:36

translate: Can't use compress_max_length_bits during qstr generation

1309ef0

jepler requested a review from dhalbert February 17, 2022 14:41

dhalbert approved these changes Feb 17, 2022

View reviewed changes

dhalbert merged commit 16c44a4 into adafruit:main Feb 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix qstr error #6047

Fix qstr error #6047

jepler commented Feb 17, 2022 •

edited

dhalbert left a comment

Fix qstr error #6047

Fix qstr error #6047

Conversation

jepler commented Feb 17, 2022 • edited

dhalbert left a comment

Choose a reason for hiding this comment

jepler commented Feb 17, 2022 •

edited