Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use --long for describe in setup.py-stubs #6064

Merged
merged 1 commit into from Feb 20, 2022

Conversation

dhalbert
Copy link
Collaborator

@dhalbert dhalbert commented Feb 19, 2022

This will use --long so setup() in setup.py will be happy when running on a tag.

@dhalbert dhalbert requested a review from jepler February 19, 2022 02:24
Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Sorry I left this time-bomb for when you made a release, but I'm not sure how it could have been made visible sooner.

@dhalbert
Copy link
Collaborator Author

@jepler Don't worry! It's very hard to test this stuff.

@jepler jepler linked an issue Feb 19, 2022 that may be closed by this pull request
@dhalbert dhalbert merged commit b3f0668 into adafruit:7.2.x Feb 20, 2022
@dhalbert dhalbert deleted the 7.2.x-tools-describe-long branch February 20, 2022 17:49
@dhalbert
Copy link
Collaborator Author

I'll merge back to main after any further rc.0 changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

git describe needs --long when used in setup() in setup.py
2 participants