Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for LILYGO TTGO T8 ESP32-S2-WROOM #6084

Merged
merged 2 commits into from Mar 9, 2022

Conversation

fabaff
Copy link

@fabaff fabaff commented Feb 23, 2022

Support for the LILYGO TTGO T8 ESP32-S2-WROOM.

This board is similar to the NanoESP32 S2 w/WROOM.

Like #6079 would this require a new VID/PID.

@fabaff fabaff changed the title Add support for LILYGO TTGO ESP32-S2-WROOM Add support for LILYGO TTGO T8 ESP32-S2-WROOM Feb 23, 2022
@fabaff
Copy link
Author

fabaff commented Feb 24, 2022

PID request: espressif/usb-pids#37

@fabaff
Copy link
Author

fabaff commented Mar 8, 2022

PID: 0x80EA

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you merge or rebase from adafruit/circuitpython? There should not be a deletion in locale/circuitpython.pot.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I'll merge once the CI completes.)

Thanks! Could you now submit a PR to https://github.com/adafruit/circuitpython-or for the board?

@dhalbert dhalbert merged commit 4420265 into adafruit:main Mar 9, 2022
@fabaff
Copy link
Author

fabaff commented Mar 9, 2022

Doc PR: adafruit/circuitpython-org#872

@fabaff fabaff deleted the lilygo-ttgo-esp32-s2 branch March 9, 2022 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants