Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

huffman is a submodule and does not need to be in requirements-dev.txt #6315

Merged
merged 1 commit into from Apr 26, 2022

Conversation

dhalbert
Copy link
Collaborator

@dhalbert dhalbert commented Apr 26, 2022

Per #6313, there are two references to huffman, and there should be only one. The one in tools/huffman is https://github.com/tannewt/huffman, and is enhanced from the PyPi one.

@dhalbert dhalbert requested a review from jepler April 26, 2022 14:34
Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this builds, it's good to merge. Thanks!

@dhalbert dhalbert merged commit 9ffd1db into adafruit:main Apr 26, 2022
@dhalbert dhalbert deleted the huffman-is-in-tools branch April 26, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants