Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add New Board - Cytron Maker Feather AIoT S3 #6382

Merged
merged 10 commits into from May 11, 2022

Conversation

waiweng83
Copy link

Added Circuit Python support for Cytron Maker Feather AIoT S3.

Thanks.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you!

@tannewt tannewt merged commit 72807bb into adafruit:main May 11, 2022
@tannewt
Copy link
Member

tannewt commented Aug 11, 2022

@waiweng83 Is this available yet? I think there may be an error in the status LED pin definition. GPIO13 should be MICROPY_HW_LED_STATUS not CIRCUITPY_STATUS_LED_POWER.

@waiweng83
Copy link
Author

@waiweng83 Is this available yet? I think there may be an error in the status LED pin definition. GPIO13 should be MICROPY_HW_LED_STATUS not CIRCUITPY_STATUS_LED_POWER.

May I know what's the different between two of them?
I actually copied this from other feather board such as "unexpectedmaker_feathers3" and "adafruit_feather_esp32s2".

FYI, this board is not launched yet as Ai-Thinker discontinues all their ESP32 modules. We have to redesign it using Espressif WROOM module and we're still testing out the prototype at the moment.

@tannewt
Copy link
Member

tannewt commented Aug 15, 2022

MICROPY_HW_LED_STATUS is meant to be a single color LED that will flash to show status (1 ok, 2 error, 3 safe mode.) CIRCUITPY_STATUS_LED_POWER is meant to enable power to the status LED. Newer Adafruit boards use this to power the NeoPixel when needed. It isn't meant to be an LED that shows power is connected.

@waiweng83
Copy link
Author

Got it. I will change it and file a new PR.
Thanks.

@waiweng83 waiweng83 deleted the add-maker-feather-aiot-s3 branch September 12, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants