Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unicode support to dotenv #7003

Merged
merged 1 commit into from Oct 6, 2022
Merged

Add unicode support to dotenv #7003

merged 1 commit into from Oct 6, 2022

Conversation

jepler
Copy link
Member

@jepler jepler commented Oct 5, 2022

Newly passing tests:

aa馃悕bb=key with emoji
value_with_emoji=aa馃悕bb

@jepler
Add unicode support to dotenv
27e6623 
Newly passing tests:
```
aa馃悕bb=key with emoji
value_with_emoji=aa馃悕bb
```
@jepler jepler requested a review from dhalbert October 5, 2022 23:19
@jepler
Copy link
Member Author

jepler commented Oct 5, 2022

@ladyada I know you were keen to have this

dhalbert
dhalbert approved these changes Oct 5, 2022
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a lot less work than I thought it would be! Thanks!

@dhalbert dhalbert merged commit ee28658 into adafruit:main Oct 6, 2022
@jepler
Copy link
Member Author

jepler commented Oct 6, 2022

utf-8 can be mostly treated as a sequence of bytes, but you have to get the signedness right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jepler @dhalbert