Traceback module improvements #7046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jepler
force-pushed
the
traceback-mod-improvements
branch
from
55393e5
to
febc7a8
Compare
dhalbert
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this is incompatible (in a minor way) I'd like to get it in before an 8.0 RC
More convenient traceback printing, Python 3.10 compatible
Python 3.10 added the form
print_traceback(exc)to print an exception and its associated traceback. This is equivalent toprint_traceback(type(exc), exc, exc.__traceback__.CPython compatible
format_tracebackOur function was documented as being compatible with CPython, which returns a list of strings. Now the implementation actually does so, rather than returning a single string. This is technically an incompatible change (vs older CircuitPython versions).
Slight size decrease
By sharing code better, a net ~16 bytes of flash memory are saved on pygamer
Tests
.. of the new way of calling, and of
format_traceback.