Attempt at pi cow ap #7101

bill88t · 2022-10-22T09:06:16Z

This is an attempt to implement access point functionallity for the pi cow.
The access point itself works.

However:

stop_ap does not work
You can connect to an access point successfully even when the ap is still running..
(This is due to CYW43_LINK_UP)

anecdata · 2022-10-22T14:53:20Z

You can connect to an access point successfully even when the ap is still running.

This is normal in espressif where you can have independent control of whether STA and / or AP are up (if I'm interpreting the statement correctly).

Also, I'm not really clear on how the cyw43 api works, but in connect, why stop_station before connecting? This breaks our working model of connect being a NOP if already connected (again, if I'm interpreting the code correctly).

bill88t · 2022-10-22T14:58:55Z

Oh sorry I didn't phrase it very well.
With the ap open, you can connect to a network and it will connect
But any pings / requests etc. will fail. cyw43 will start crying debug messages.
I just have to fix the stop_ap and call it before a connection.

anecdata · 2022-10-22T14:59:36Z

OK, sorry, missed that this was in draft. I'm excited about the feature :-)

paul-1 · 2022-11-03T14:02:44Z

Outside of running both AP and STA modes at the same time. The AP is working really nice. I have made a few tweaks outside of what @bill88t has done here.

Added wifi channel selection when starting the AP. The interesting thing with this is that the channel can only be set on the first run after cold boot. If you do a warm reset, the radio will not change to a different channel.
Enabled dhcpserver for the AP. This is a compile time option.

I have the changes that I've made here: https://github.com/paul-1/circuitpython/tree/picow-AP-mode-with-DHCP-server

…uture improvements to allow country code setting.

bill88t · 2022-11-10T15:28:53Z

Updated my local branch, cherry-picked the commits from paul-1's fork, thanks @paul-1!
And I am now giving it another try.
As soon as I get the disconnection working, we should be able to merge this.

paul-1 · 2022-11-10T16:19:14Z

Not sure if you or anyone has some advice about the country code commit. I know we are initializing the wifi chip early, so that the digital pins are available for general use. That appears to be the only time we can set the country code. The default wifi country is a global wifi policy.

Perhaps before wifi init we should use getenv to look at see if the user has a valid country code defined in the .env file?

tannewt · 2022-11-15T23:08:26Z

Perhaps before wifi init we should use getenv to look at see if the user has a valid country code defined in the .env file?

That sounds like a good use for .env! 👍

bill88t · 2022-11-17T17:00:52Z

I cannot get the ap to stop no matter what I do..
This is due to cyw43_wifi_leave being borked and doing nothing.

Looking at the respective micropython code we can see, they haven't implemented it either.

I will continue implementing the AP, without stop_ap.
stop_ap will simply raise an appropriate error. Feel free to suggest error messages.
What I propose is NotImplementedError: AP cannot be disconnected.

anecdata · 2022-11-17T17:23:56Z

What happens if start_ap() is called a second time, with different parameters such as ssid or password?

Do we have any API to access cyw43_deinit() to shut it all down and start over (short of a CircuitPython reload)?

bill88t · 2022-11-17T18:26:59Z

What happens if start_ap() is called a second time, with different parameters such as ssid or password?

Stays on original ssid and accepts no connections.
This applies for same ssid, different passwd
different ssid, same passwd
different ssid, different passwd

Do we have any API to access cyw43_deinit() to shut it all down and start over (short of a CircuitPython reload)?

Aren't some pins controlled from the wifi chip?
It would be pretty problematic resetting.
Pretty sure this is the reason it hasn't been implemented so far.

Note: I have not touched any of the early-boot cyw43 code.
I absolutely do not know a thing.

bill88t · 2022-11-17T19:53:47Z

Now, wifi.radio.start_ap, wifi.radio.stop_ap, wifi.radio.connect and wifi.radio.stop_station are ready.
I only now need to do the getters for the ap.

The error messages I added are very much suboptimal. I would very much appreciate some suggestions.

paul-1 · 2022-11-17T21:58:39Z

TBH, I'm not sure there is significant value top stop the AP during a running program. Changing the AP SSID/password, then restarting the code worked fine when I previously tested. I think there are things that just requires the radio to be hard power cycled. For example, once the AP is started the channel assignment will not change without a hard power cycle.

I looked at the error messages. "cannot be stopped" has the connotation that something is preventing it from stopping. IMO, "Stopping AP is not supported" is a better choice.

anecdata · 2022-11-17T22:06:33Z

I have an application (on ESP32-S*) that sets up different SSIDs at different times during a run.

We are (hopefully) trying to have a single consistent wifi API for both espressif and raspberrypi, but unfortunately the raspberrypi underpinnings are less mature / less granular, so we'll have some limitations (for now?)

bill88t · 2022-11-17T22:12:45Z

Hopefully as cyw43 is updated, this stuff will be fixed.
However now we are stuck with what we got.
microcontroller.reset() is still an option.

paul-1 · 2022-11-18T01:31:43Z

"Significant Value" was a poor choice of words, on my part. I agree with common api within CP. Since we have to wait for SDK/firmware improvements, I propose we just stick with the current state of the AP development. Cleanup and merge for 8.0.0, and add an open issue or milestone to re-evaluate for future releases.

bill88t · 2022-11-20T11:16:44Z

Actually ap_info is for "the access point we are connected to". So there is nothing more to implement.
Ready for review.

anecdata

Differences from espressif, from above and from testing:

Station and AP can’t operate simultaneously
-- if device AP is started, device Station can't connect to an external AP (~~RuntimeError: Already in access point mode.~~ RuntimeError: Wifi is in access point mode.)
-- If device Station is connected to an external AP, device AP can't be started (~~RuntimeError: Already connected to station.~~ RuntimeError: Wifi is in station mode.)
once an AP is started, it can't be stopped without a power cycle or microcontroller.reset()
AP channel (edit: and other AP settings) can only be set once after a power cycle or microcontroller.reset()
wifi.radio.enabled is not implemented (AttributeError: 'Radio' object has no attribute 'enabled'), so to disconnect from an external AP, use wifi.radio.stop_station() --> EDIT: this has now been implemented --> EDIT 2: .enabled isn't fully implemented, but is checked when trying to start a station or AP..

Thanks!

Addendum:

wifi country is set to global wifi policy

ports/raspberrypi/common-hal/wifi/Radio.c

bill88t · 2022-11-21T23:06:31Z

once an AP is started, it can't be stopped

Or even have its settings changed.
You get one shot. 😅

anecdata

Everything I've tried is working as expected. Just ran an adafruit_httpserver on the wifi AP, and connected with a CircuitPython client and got served. I'm going to approve this and defer to one of the core devs to decide to merge. It would be nice to get this out there for more folks to poke at it :-)

bill88t · 2022-11-23T15:26:39Z

1211248 bytes used, 357520 bytes free in flash firmware space out of 1568768 bytes (1532.0kB).
66592 bytes used, 195552 bytes free in ram for stack and heap out of 262144 bytes (256.0kB).

Just in case anyone cares about free board storage.

dhalbert · 2022-11-30T16:18:20Z

@jepler Could you look this over before we merge? Thanks.

@bill88t There are now merge conflicts that need to be resolved.

bill88t · 2022-11-30T17:36:39Z

Built and tested locally.

1259888 bytes used, 308880 bytes free in flash firmware space out of 1568768 bytes (1532.0kB).
69044 bytes used, 193100 bytes free in ram for stack and heap out of 262144 bytes (256.0kB).

One thing I noticed however, these messages pop up whenever a device connects.
DHCPS: client connected: MAC=8a:ab:19:62:52:ad IP=192.168.4.16
The build is not a debug build. I'm pretty sure they should be disabled on regular builds.

bill88t · 2022-11-30T17:45:39Z

shared/netutils/dhcpserver.c:268
Why isn't there 'some' condition? This needs to be silenced in some way..

jepler · 2022-11-30T17:50:12Z

perhaps

diff --git a/shared/netutils/dhcpserver.c b/shared/netutils/dhcpserver.c
index a61501c93c..d396a2ba56 100644
--- a/shared/netutils/dhcpserver.c
+++ b/shared/netutils/dhcpserver.c
@@ -265,9 +265,9 @@ static void dhcp_server_process(void *arg, struct udp_pcb *upcb, struct pbuf *p,
             d->lease[yi].expiry = (mp_hal_ticks_ms() + DEFAULT_LEASE_TIME_S * 1000) >> 16;
             dhcp_msg.yiaddr[3] = DHCPS_BASE_IP + yi;
             opt_write_u8(&opt, DHCP_OPT_MSG_TYPE, DHCPACK);
-            printf("DHCPS: client connected: MAC=%02x:%02x:%02x:%02x:%02x:%02x IP=%u.%u.%u.%u\n",
+            LWIP_DEBUGF(DHCP_DEBUG, ("DHCPS: client connected: MAC=%02x:%02x:%02x:%02x:%02x:%02x IP=%u.%u.%u.%u\n",
                 dhcp_msg.chaddr[0], dhcp_msg.chaddr[1], dhcp_msg.chaddr[2], dhcp_msg.chaddr[3], dhcp_msg.chaddr[4], dhcp_msg.chaddr[5],
-                dhcp_msg.yiaddr[0], dhcp_msg.yiaddr[1], dhcp_msg.yiaddr[2], dhcp_msg.yiaddr[3]);
+                dhcp_msg.yiaddr[0], dhcp_msg.yiaddr[1], dhcp_msg.yiaddr[2], dhcp_msg.yiaddr[3]));
             break;
         }

bill88t · 2022-11-30T17:57:35Z

Oh I thought it was a submodule. Thankfully it is not.
Imma test it just in case (w & wo/ debug), and we are good to go.

jepler

Thanks for working on this! No testing performed.

ports/raspberrypi/Makefile

ports/raspberrypi/common-hal/wifi/Radio.c

ports/raspberrypi/supervisor/port.c

jepler

Thank you again!

bill88t · 2022-11-30T20:29:34Z

Now when DEBUG=1, dhcps should announce connections.
This debugging info is useful and shouldn't be barriered behind the header file.
Testing, and I am done with this pr.

jepler · 2022-11-30T20:29:28Z

shared/netutils/dhcpserver.h

@@ -31,6 +31,10 @@
 #define DHCPS_BASE_IP (16)
 #define DHCPS_MAX_IP (8)

+#ifndef DHCP_DEBUG
+#define DHCP_DEBUG    LWIP_DBG_ON


won't this turn the debug messages back on? is that what you intended?

When DEBUG=0 the user shouldn't see them.
When DEBUG=1 you probably want them.

It builds (w & wo/ debug) but doesn't work though, and I am not sure why.

bill88t · 2022-11-30T20:48:55Z

Idk how to fix it, and it really doesn't matter.
I will continue testing locally, and follow up with more pr's on picow ap.
As much as this one is concerned, done.

jepler

Thanks! I do not have a strong opinion about that dhcp debug message, it can be fixed in the future with a fresh PR.

bill88t added 2 commits October 21, 2022 13:20

PicoW start_ap()

8cc536b

PicoW more ap work

7a50beb

anecdata mentioned this pull request Nov 5, 2022

can i start_ap() without connecting to a network? #7172

Closed

bill88t and others added 4 commits November 10, 2022 17:04

Merge branch 'adafruit:main' into picow-ap

25c0a0a

picow: enable dhcpserver for apmode.

8fdb2df

picow: Add channel setting when starting AP

851c2cd

picow: Change init to use country code routine.....place holder for f…

11f1174

…uture improvements to allow country code setting.

Merge branch 'adafruit:main' into picow-ap

a234b74

picow-ap progress

b8cd6c0

just change the ap error

88bd9ef

bill88t marked this pull request as ready for review November 20, 2022 11:16

anecdata reviewed Nov 21, 2022

View reviewed changes

ports/raspberrypi/common-hal/wifi/Radio.c Outdated Show resolved Hide resolved

Error msg changes

b40facd

anecdata previously approved these changes Nov 22, 2022

View reviewed changes

dhalbert requested a review from jepler November 30, 2022 16:17

Merge branch 'main' into picow-ap

362018d

bill88t dismissed anecdata’s stale review via 362018d November 30, 2022 17:11

fix picow-ap

44d5326

jepler previously approved these changes Nov 30, 2022

View reviewed changes

ports/raspberrypi/Makefile Show resolved Hide resolved

ports/raspberrypi/common-hal/wifi/Radio.c Outdated Show resolved Hide resolved

ports/raspberrypi/common-hal/wifi/Radio.c Show resolved Hide resolved

ports/raspberrypi/supervisor/port.c Show resolved Hide resolved

Change comment, and logic on dhcpserver

f8070d2

bill88t dismissed jepler’s stale review via f8070d2 November 30, 2022 19:52

jepler previously approved these changes Nov 30, 2022

View reviewed changes

debug_dhcp to follow general debug

0738d50

bill88t dismissed jepler’s stale review via 0738d50 November 30, 2022 20:25

jepler reviewed Nov 30, 2022

View reviewed changes

Revert "debug_dhcp to follow general debug"

3fb4fd8

jepler approved these changes Dec 2, 2022

View reviewed changes

jepler merged commit ddc56f5 into adafruit:main Dec 2, 2022

bill88t deleted the picow-ap branch December 7, 2022 19:10

anecdata mentioned this pull request Feb 21, 2023

cannot start access point mode for Raspberry Pi Pico W. the error is: RuntimeError: Wifi is in station mode. #7620

Closed

eightycc mentioned this pull request Nov 12, 2023

Pico W simple AP code is boot looping #8138

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Attempt at pi cow ap #7101

Attempt at pi cow ap #7101

bill88t commented Oct 22, 2022

anecdata commented Oct 22, 2022 •

edited

bill88t commented Oct 22, 2022 •

edited

anecdata commented Oct 22, 2022 •

edited

paul-1 commented Nov 3, 2022

bill88t commented Nov 10, 2022

paul-1 commented Nov 10, 2022

tannewt commented Nov 15, 2022

bill88t commented Nov 17, 2022

anecdata commented Nov 17, 2022 •

edited

bill88t commented Nov 17, 2022 •

edited

bill88t commented Nov 17, 2022

paul-1 commented Nov 17, 2022

anecdata commented Nov 17, 2022

bill88t commented Nov 17, 2022

paul-1 commented Nov 18, 2022

bill88t commented Nov 20, 2022

anecdata left a comment •

edited

bill88t commented Nov 21, 2022

anecdata left a comment

bill88t commented Nov 23, 2022 •

edited

dhalbert commented Nov 30, 2022

bill88t commented Nov 30, 2022

bill88t commented Nov 30, 2022

jepler commented Nov 30, 2022

bill88t commented Nov 30, 2022

jepler left a comment

jepler left a comment

bill88t commented Nov 30, 2022

jepler Nov 30, 2022

bill88t Nov 30, 2022

bill88t Nov 30, 2022

bill88t commented Nov 30, 2022

jepler left a comment

Attempt at pi cow ap #7101

Attempt at pi cow ap #7101

Conversation

bill88t commented Oct 22, 2022

anecdata commented Oct 22, 2022 • edited

bill88t commented Oct 22, 2022 • edited

anecdata commented Oct 22, 2022 • edited

paul-1 commented Nov 3, 2022

bill88t commented Nov 10, 2022

paul-1 commented Nov 10, 2022

tannewt commented Nov 15, 2022

bill88t commented Nov 17, 2022

anecdata commented Nov 17, 2022 • edited

bill88t commented Nov 17, 2022 • edited

bill88t commented Nov 17, 2022

paul-1 commented Nov 17, 2022

anecdata commented Nov 17, 2022

bill88t commented Nov 17, 2022

paul-1 commented Nov 18, 2022

bill88t commented Nov 20, 2022

anecdata left a comment • edited

Choose a reason for hiding this comment

bill88t commented Nov 21, 2022

anecdata left a comment

Choose a reason for hiding this comment

bill88t commented Nov 23, 2022 • edited

dhalbert commented Nov 30, 2022

bill88t commented Nov 30, 2022

bill88t commented Nov 30, 2022

jepler commented Nov 30, 2022

bill88t commented Nov 30, 2022

jepler left a comment

Choose a reason for hiding this comment

jepler left a comment

Choose a reason for hiding this comment

bill88t commented Nov 30, 2022

jepler Nov 30, 2022

Choose a reason for hiding this comment

bill88t Nov 30, 2022

Choose a reason for hiding this comment

bill88t Nov 30, 2022

Choose a reason for hiding this comment

bill88t commented Nov 30, 2022

jepler left a comment

Choose a reason for hiding this comment

anecdata commented Oct 22, 2022 •

edited

bill88t commented Oct 22, 2022 •

edited

anecdata commented Oct 22, 2022 •

edited

anecdata commented Nov 17, 2022 •

edited

bill88t commented Nov 17, 2022 •

edited

anecdata left a comment •

edited

bill88t commented Nov 23, 2022 •

edited