Add Maker badge board

[dronecz]

Thanks🙂

[dronecz]

Failed just at my board, which is expected as my PR is not merged. Am I right or should I look in to it again?

[dhalbert]

Failed just at my board, which is expected as my PR is not merged. Am I right or should I look in to it again?

No, your board should not fail. It looks like the sdkconfig file is missing: see https://github.com/adafruit/circuitpython/actions/runs/3357317522/jobs/5563100639.

But there are far too many changed files here. Don't add the frozen libraries directly by copying. Add them as git submodules.

[dronecz]

Still unhappy about something 😕

Note: Not building languages {'hi', 'ko', 'cs', 'el'}
building boards with parallelism 2
Error: Build maker_badge for de_DE took 0.66s and failed
make: Entering directory '/home/runner/work/circuitpython/circuitpython/ports/espressif'
Use make V=1, make V=2 or set BUILD_VERBOSE similarly in your environment to increase build verbosity.
make: *** No rule to make target 'boards/maker_badge/sdkconfig', needed by 'build-maker_badge/esp-idf/config/sdkconfig.h'.  Stop.
make: *** Waiting for unfinished jobs....
mkdir -p build-maker_badge/genhdr
make: Leaving directory '/home/runner/work/circuitpython/circuitpython/ports/espressif'

Cannot find file ../ports/espressif/build-maker_badge/firmware.uf2

Should I add localy build firmware.uf2 file?

[jepler]

This pull request isn't building because espressif boards each need an "sdkconfig" file. The specific contents of the sdkconfig file depend on the espressif chip / module used.

Not all sdkconfig settings have to be in this file, but these do:

• the size and speed of spiram
• psram pinout information, in some cases

For example, this is the sdkconfig file for the kaluga devkit: https://github.com/adafruit/circuitpython/blob/main/ports/espressif/boards/espressif_kaluga_1.3/sdkconfig

I'm not 100% sure of the details of this file.

[jepler]

The safe mode messages were recently re-worked. As a result, this line is not needed. Please remove this line. When CIRCUITPY_BOOT_BUTTON is defined, a predefined message is used:

            message = translate("The BOOT button was pressed at start up.\n");

[dronecz]

Thanks, I removed that line 🙂

[jepler]

CIRCUITPY_MODULE is no longer used. Remove this line.

[dronecz]

Thanks, I removed that line 🙂

[jepler]

An "IDF_TARGET" line is needed. For instance, if the specific microcontroller is esp32-s2 then it would be

IDF_TARGET = esp32s2

Also, can you verify that you did actually remove the unneeded lines I mentioned before?

[jepler]

These lines are not needed, because these are defaults on espressif. Remove them please.

[dronecz]

Thanks, I removed those lines 🙂

[jepler]

Hi and thanks for the PR! I have some comments / requested changes. I'm sorry that I don't know enough about the sdkconfig file to guide you through getting the right content into it.

[dronecz]

Thank you @jepler I could build localy so I was confused, why this build failed. I had sdkconfig file localy, but I do not know why, but I did not copy it to PR 🤦‍♂️. I hope this will build.

[jepler]

The failures you're seeing now are due to an incompatibility of esp-idf and python 3.11, which has started rolling out on github actions. I filed a PR to pin our python back at 3.10 during the build: #7164

[dronecz]

The failures you're seeing now are due to an incompatibility of esp-idf and python 3.11, which has started rolling out on github actions. I filed a PR to pin our python back at 3.10 during the build: #7164

Thanks 🙂 Is there way, how can I restart build without making changes to my code?

[jepler]

I updated the PR to remove the change to circuitpython.pot, which is unneeded now anyway. This should cause a fresh re-builld with the fix to the python 3.11 problem too.

[jepler]

The filename is misspelled

[dronecz]

Thank you! I missed that. 😩

[dronecz]

@jepler It is again failing at language files. I really do not need circuitpython.pot file? Thanks

[jepler]

The build is failing for the following reason:

make: *** No rule to make target '../../frozen/Adafruit_CircuitPython_UC8151D', needed by 'build-maker_badge/frozen_mpy'.  Stop.

Additional steps are needed to properly add a new frozen module that has never been included before in any board. We have a guide on doing this via git on your local computer: https://learn.adafruit.com/building-circuitpython/adding-frozen-modules -- as far as I know you can't add a new submodule merely by the github website interface.

[jepler]

The build failed for the following reason:

subprocess.CalledProcessError: Command 'git describe --tags --exact-match' returned non-zero exit status 128.

as a policy, each frozen submodule must point exactly at a tag (release), not at another ref. There's a script for updating all libraries. I ran it and updated your branch, so maybe this time it will build successfully.

[dronecz]

@jepler Many thanks for your help! I tried to fix it yesterday at my local build, but without success. Do you have more info about that script to fix this issue? I saw this information at page, which you linked earlier, but I did not figure out how to make it work.

It would be good to mention that script in the learn guide, so peple will not strugle to fix same issue.

[jepler]

The command is "make update-frozen-libraries" in the top level directory. I left feedback on the guide using the " Feedback? Corrections?" link so hopefully the maintainer will incorporate the suggestion soon.

[jepler]

Thanks! It's taken a bit of time and I appreciate your responsiveness to my questions and suggestions. I think it's ready now.

[jepler]

An "IDF_TARGET" line is needed. For instance, if the specific microcontroller is esp32-s2 then it would be

IDF_TARGET = esp32s2

Also, can you verify that you did actually remove the unneeded lines I mentioned before?

[dhalbert]

I left feedback on the guide using the " Feedback? Corrections?" link so hopefully the maintainer will incorporate the suggestion soon.

Done.