Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change boot button message to an independent sentence #7150

Merged
merged 3 commits into from
Oct 30, 2022

Conversation

Neradoc
Copy link

@Neradoc Neradoc commented Oct 29, 2022

resolves #7149
Removes a few messages mentioning the boot button, since that is the default anyway (if a boot button is defined).
The format is now:

You are in safe mode because:
Both buttons were pressed at start up.
To exit, please reset the board without requesting safe mode.

@dhalbert
Copy link
Collaborator

The Feather M0 RFM69 does not fit. There's not really anything obvious I can turn off, but I think the frozen library can be shrunk a bit without much difficulty.

@Neradoc
Copy link
Author

Neradoc commented Oct 30, 2022

So I changed the if (message != NULL) into a #if defined that I thought would have been optimized away anyway, so hopefully I didn't remove functionality in the process. Somehow it won us 16 bytes on the RFM69 from the previous run.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, that narrow change is what we needed! I'll merge to get this in to beta.4.

I looked at the size of the RFM69 ru build before this PR, and it had exactly 0 bytes remainining!

It would still be good to shrink that library a bit, since this will happen again.

@dhalbert dhalbert merged commit 28c9aff into adafruit:main Oct 30, 2022
@Neradoc Neradoc deleted the cleanup-boot-button-message branch March 19, 2023 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make BOARD_USER_SAFE_MODE_ACTION not be a simple concatenation to a sentence fragment
2 participants