Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add boards list to make error message #7162

Merged
merged 6 commits into from
Nov 22, 2022
Merged

add boards list to make error message #7162

merged 6 commits into from
Nov 22, 2022

Conversation

rhooper
Copy link

@rhooper rhooper commented Nov 1, 2022

Adds the list of boards to the error output of make boards

dhalbert
dhalbert requested changes Nov 1, 2022
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cuing the user! Are you willing to do this for the Makefiles in the other ports too?

jepler
jepler reviewed Nov 1, 2022
View reviewed changes
ports/atmel-samd/Makefile Outdated Show resolved Hide resolved
@tannewt
Copy link
Member

tannewt commented Nov 15, 2022

Is this waiting to be copied into the other ports' Makefiles?

@rhooper
Copy link
Author

rhooper commented Nov 16, 2022

Is this waiting to be copied into the other ports' Makefiles?

I think so.

@microdev1 @rhooper @jepler
add awesome new make error message
e2a3597 
Copied from initial implementation on atmel-samd

Co-authored-by: Rose Hooper <rhooper@toybox.ca>
Co-authored-by: Jeff Epler <jepler@gmail.com>
dhalbert
dhalbert requested changes Nov 18, 2022
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you refactor the definition of show_board_error and the check into an existing or new .mk file so that it doesn't need to be duplicated in every file?

dhalbert
dhalbert approved these changes Nov 22, 2022
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for generalizing!

@dhalbert dhalbert merged commit 6d02273 into adafruit:main Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jepler jepler jepler left review comments

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
enhancement hacktoberfest-accepted tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rhooper @tannewt @jepler @dhalbert @microdev1 @tekktrik