Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STM32L4 PDMIn support #7169

Merged
merged 3 commits into from
Nov 9, 2022
Merged

STM32L4 PDMIn support #7169

merged 3 commits into from
Nov 9, 2022

Conversation

m-mcgowan
Copy link

@m-mcgowan m-mcgowan commented Nov 4, 2022 •
edited

Implements PDMIn for STM32L4/Swan R5 using the SAI peripheral and decimation/filtering in software.

In addition to the the PDMIn module, this PR also enables native compilation and displayio on Swan R5, which has worked fine in our testing.

@m-mcgowan
Copy link
Author

m-mcgowan commented Nov 5, 2022 •
edited

Two checks in the build-arm job failed retrieving external dependencies due to a limit on the number of times a URL can be requested. I don't have access to re-run these checks - grateful if someone with access can re-run these failed checks for me. Thanks!

dhalbert
dhalbert requested changes Nov 8, 2022
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this work. I have some minor comments.

Consider redoing the copyright lines on files you have modified extensively.

ports/stm/common-hal/audiobusio/PDMIn.c Show resolved Hide resolved
ports/stm/boards/swan_r5/mpconfigboard.mk Outdated Show resolved Hide resolved
@m-mcgowan
formatting(swan_r5): lexicographically sorted the board module names …
843d6b4 
…in the swan_r5 makefile include [ci-skip][skip-ci]. Skip CI since this is a cosmetic change only.
@m-mcgowan
docs(swan_r5): updated copyright notices
97f693d
@m-mcgowan
Copy link
Author

@dhalbert - I've made the changes suggested. It would be great if you could approve and merge this PR.

dhalbert
dhalbert approved these changes Nov 9, 2022
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, this looks good! Sorry for the delay.

@dhalbert dhalbert merged commit e6936de into adafruit:main Nov 9, 2022
@m-mcgowan
Copy link
Author

Oh no worries, thank you for reviewing and approving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@m-mcgowan @dhalbert