Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pi cow debug compilation #7192

Merged
merged 7 commits into from
Nov 15, 2022
Merged

Fix pi cow debug compilation #7192

merged 7 commits into from
Nov 15, 2022

Conversation

bill88t
Copy link

@bill88t bill88t commented Nov 11, 2022

It now compiles with DEBUG=1.

@bill88t bill88t marked this pull request as ready for review November 11, 2022 12:19
u32_t -> uint32_t

Co-authored-by: MicroDev <70126934+MicroDev1@users.noreply.github.com>
@bill88t
Copy link
Author

bill88t commented Nov 11, 2022

If the uint32_t doesn't work, I will revert it later. I will test it with debug anyways.

@bill88t
Copy link
Author

bill88t commented Nov 14, 2022

Now, the lwip_src folder is completely unused. And ping_time is captured.

I will probably do a cleanup commit and then test the changes on some real hardware.
Converting to draft till done.

@bill88t bill88t marked this pull request as draft November 14, 2022 16:41
@bill88t
Copy link
Author

bill88t commented Nov 14, 2022

Ljinux raspberry_pi_pico_w 0.3.6-dev 01/01/2020 00:00:07 circuitpython Ljinux

[board@ljinux| ~]> modprobe driver_wifi as network
API: 12.2
Data: RaspberryPi.PicoW
Compiler: 1.29.4
ClmImport: 1.47.1
Customization: v5 22/06/24
Creation: 2022-06-24 06:55:08
[board@ljinux| ~]> iwctl --passphrase "[REDACTED]" station wifi connect Pi400
[board@ljinux| ~]> ping feline.gr
PING feline.gr (95.216.7.161) data.
ping: send 95.216.7.161
ping: recv 95.216.7.161 81 ms
PING from feline.gr: icmp_seq=1 time=83.0 ms
ping: send 95.216.7.161
ping: recv 95.216.7.161 81 ms
PING from feline.gr: icmp_seq=2 time=82.0 ms
ping: send 95.216.7.161
ping: recv 95.216.7.161 82 ms
PING from feline.gr: icmp_seq=3 time=82.0 ms
ping: send 95.216.7.161
ping: recv 95.216.7.161 82 ms
PING from feline.gr: icmp_seq=4 time=82.0 ms
ping: send 95.216.7.161
ping: recv 95.216.7.161 82 ms
PING from feline.gr: icmp_seq=5 time=82.0 ms
ping: send 95.216.7.161
ping: recv 95.216.7.161 82 ms
PING from feline.gr: icmp_seq=6 time=82.0 ms
ping: send 95.216.7.161
ping: recv 95.216.7.161 82 ms
PING from feline.gr: icmp_seq=7 time=82.0 ms
ping: send 95.216.7.161
ping: recv 95.216.7.161 81 ms
PING from feline.gr: icmp_seq=8 time=82.0 ms
ping: send 95.216.7.161
ping: recv 95.216.7.161 81 ms
PING from feline.gr: icmp_seq=9 time=82.0 ms
^C
--- feline.gr ping statistics ---
9 packets transmitted, 9 received, 0 lost
rtt min/avg/max/mdev = 82.0/82.1/83.0/0.3 ms
[board@ljinux| ~]> 

The

API: 12.2
Data: RaspberryPi.PicoW
Compiler: 1.29.4
ClmImport: 1.47.1
Customization: v5 22/06/24
Creation: 2022-06-24 06:55:08

and

ping: send 95.216.7.161
ping: recv 95.216.7.161 81 ms

lines are the debug lines

@bill88t bill88t marked this pull request as ready for review November 14, 2022 17:34
@bill88t
Copy link
Author

bill88t commented Nov 14, 2022

Now it doesn't build without debug..

This reverts commit 398e912.
It fails on LINK without them.
@bill88t
Copy link
Author

bill88t commented Nov 15, 2022

I have retested, and this is ready to go.

@jepler
Copy link
Member

jepler commented Nov 15, 2022

@tannewt want to review this as a way to stick your toes in the pico w waters?

@tannewt
Copy link
Member

tannewt commented Nov 15, 2022

Give me a bit more time before I touch LWIP stuff. (So I'll pass.)

Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I am still not 100% confident about the way ping_time is used across two source files (Radio.c and ping.c), whether they need to be the same or whether they need to be different; but your logs seem to show that it "works now".

A note for the future: Because I don't know a single thing about your "ljinux" environment -- and the majority of reviewers won't either -- it is more difficult for me to analyze and understand what I am seeing, compared to just seeing Python code. If in the future you can show Python code instead, I do not have to guess and possibly make wrong assumptions about what you are actually demonstrating. Just something to keep in mind that could help us communicate better together.

@jepler jepler merged commit ef93eda into adafruit:main Nov 15, 2022
@bill88t bill88t deleted the picow-debug branch November 22, 2022 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants