-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pi cow debug compilation #7192
Conversation
u32_t -> uint32_t Co-authored-by: MicroDev <70126934+MicroDev1@users.noreply.github.com>
If the uint32_t doesn't work, I will revert it later. I will test it with debug anyways. |
Now, the I will probably do a cleanup commit and then test the changes on some real hardware. |
The
and
lines are the debug lines |
Now it doesn't build without debug.. |
This reverts commit 398e912. It fails on LINK without them.
I have retested, and this is ready to go. |
@tannewt want to review this as a way to stick your toes in the pico w waters? |
Give me a bit more time before I touch LWIP stuff. (So I'll pass.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I am still not 100% confident about the way ping_time
is used across two source files (Radio.c and ping.c), whether they need to be the same or whether they need to be different; but your logs seem to show that it "works now".
A note for the future: Because I don't know a single thing about your "ljinux" environment -- and the majority of reviewers won't either -- it is more difficult for me to analyze and understand what I am seeing, compared to just seeing Python code. If in the future you can show Python code instead, I do not have to guess and possibly make wrong assumptions about what you are actually demonstrating. Just something to keep in mind that could help us communicate better together.
It now compiles with
DEBUG=1
.