Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new board crcibernetica-ideaboard #7198

Merged
merged 2 commits into from
Nov 13, 2022

Conversation

bborncr
Copy link

@bborncr bborncr commented Nov 12, 2022

This is an ESP32 WROOM based board. The board files modeled after the adafruit-feather-huzzah32.

@dhalbert
Copy link
Collaborator

Espressif boards need an sdkconfig as well as the other files mentioned in the guide. The best starting point is an sdkconfig from a similar board, with the same chip, etc.

@bborncr
Copy link
Author

bborncr commented Nov 13, 2022

I have an sdkconfig file. The board is basically a copy of the Adafruit Feather Huzzah32 with pin changes. It appears that a .gitignore file removes the sdkconfig file.

@bborncr
Copy link
Author

bborncr commented Nov 13, 2022

Here is the .gitignore that I believe removes my sdkconfig file:
https://github.com/adafruit/circuitpython/blob/main/ports/espressif/.gitignore

@Neradoc
Copy link

Neradoc commented Nov 13, 2022

Oh yeah, I was working on adding a C3 board today and noticed that ports/espressif/.gitignore now ignores sdkconfig* (I noticed because it made ag skip those files by default). This comes from #6974

@dhalbert
Copy link
Collaborator

@microdev1 Notice the .gitignore issue above, from #6974.

@microdev1
Copy link
Collaborator

@microdev1 Notice the .gitignore issue above, from #6974.

Following should allow inclusion of board skdconfig while blocking build files.

-sdkconfig*
+./sdkconfig*

@bborncr Can you make the changes? It seems like "Allow edit by maintainers" is turned off for this PR.

@bborncr
Copy link
Author

bborncr commented Nov 13, 2022

Great! It worked! However, should it have built all Espressif boards?

@dhalbert
Copy link
Collaborator

Great! It worked! However, should it have built all Espressif boards?

Yes, because changing the .gitignore file was at the top of ports/espressif, so it potentially influences anything below it.

@dhalbert dhalbert merged commit 6e9909c into adafruit:main Nov 13, 2022
@bborncr bborncr deleted the crcibernetica-ideaboard branch November 13, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants