Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return to using python 3.x for builds #7204

Merged
merged 4 commits into from
Nov 30, 2022
Merged

Conversation

jepler
Copy link
Member

@jepler jepler commented Nov 13, 2022

Also requires adafruit/esp-idf#7

Also closes #7205.

@jepler jepler marked this pull request as ready for review November 28, 2022 19:56
@jepler
Copy link
Member Author

jepler commented Nov 28, 2022

Marking as ready for review, but requires adafruit/esp-idf#7 to be reviewed & merged first.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved and merged adafruit/esp-idf#7. Could you change the esp-idf submodule commit to the merge commit for adafruit/esp-idf#7? Thanks.

@jepler jepler requested a review from dhalbert November 30, 2022 18:05
@jepler
Copy link
Member Author

jepler commented Nov 30, 2022

Updated!

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dhalbert dhalbert merged commit 845b68c into adafruit:main Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

changes to workflow files should make docs build
2 participants