shared-bindings: Get rid of CYW43 special cases in shared-bindings #7207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalbert
previously approved these changes
Nov 14, 2022
jepler
changed the title
.. by moving it into a new weak function that can be replaced just by the picow build.
jepler
force-pushed
the
nicer-pin-checking
branch
from
d64a7bd
to
cdab078
Compare
|
I fixed (I hope) the build errors and re-titled the PR since the phrase "non-public code" could be open to misinterpretation :) |
dhalbert
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.. by moving it into a new weak function that can be replaced just by the picow build.
I was stewing about this and Dan also mentioned that the way that cyw43 poked its head out into shared-bindings was gross. A weak function that allows the port to substitute a different check is a way to move the complexity back where it belongs.