Add support for the 16MB WeAct Studio Pico #7208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You'll want to add an entry here to share the USB VID/PID with the other version: https://github.com/adafruit/circuitpython/blob/main/tools/ci_check_duplicate_usb_vid_pid.py#L33 |
|
Presumably I also need to make a PR at https://github.com/adafruit/circuitpython-org for this board variant? |
Yes please! |
|
Is this needed? The rp2040 port auto detects flash size so it should work fine with the 2mb definition |
|
@prplz Maybe not. I think its ok to have though. Explicit tends to be better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #6411, and based on Fabian's work there.
I only have the 16MB board, so as I can't test them I haven't added the 4 and 8MB versions.