STM: off-by-one TIMx reference; other code cleanup and minor fixes #7212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jepler
reviewed
Nov 15, 2022
|
oh, because the PR had already been merged, that's why. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7040.
stm_peripherals_timer_get_source_freq()was off by one in its TIMx numbering assumption, causing incorrect lookups of some timer frequencies.PulseIn.c, timer clock reset was being done with an integer instead of a bitmask. Noticed this while looking for other manifestations of the previous bug.stm_peripherals_timer_get_source_freq()to handle other variants of STM chips. Not tested, but would have been wrong otherwise.PWMOuta bit for clarity and to make any returned errors more accurate.