fix playing mono files on stereo output #7253
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing #5932, I discovered a different problem, which is that mono files played back on SAMD51 on stereo channels caused a buzz every other time. This was due to not checking the number of channels when setting up the DMA's.
Now, a mono file will play in only one channel if there are stereo channels. If two DMA's are set up (depends on the channel order), then the mono file would play twice as fast (I guess double incrementing is going on). This may be fixable but I think requires some internal API changes.
This is not the perfect fix, but is an improvement over the current situation, because it gets rid of poor sound quality (buzz) when playing mono files on stereo.