Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle domain with trailing dot #7281

Merged
merged 1 commit into from
Nov 30, 2022
Merged

handle domain with trailing dot #7281

merged 1 commit into from
Nov 30, 2022

Conversation

jepler
Copy link
Member

@jepler jepler commented Nov 30, 2022

Closes: #7032

dhalbert
dhalbert approved these changes Nov 30, 2022
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple -- thanks!

@dhalbert dhalbert merged commit 2f5ec1c into adafruit:main Nov 30, 2022
@anecdata
Copy link
Member

Tested. espressif and raspberrypi now both handle URLs with FQDN with trailing dot (including mDNS .local/.local.). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

espressif: fails to resolve FQDNs with trailing "."
3 participants
@jepler @anecdata @dhalbert