Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tj-actions & Revert fetch-depth change #7332

Merged
merged 3 commits into from Jan 5, 2023
Merged

Update tj-actions & Revert fetch-depth change #7332

merged 3 commits into from Jan 5, 2023

Conversation

microdev1
Copy link
Collaborator

The latest working tj-actions/changed-files version is v34.5.1. Also, reverts fetch-depth change introduced in #7329.

@microdev1 microdev1 linked an issue Dec 11, 2022 that may be closed by this pull request
CI builds failing in tj-actions/changed-files #7328
Closed
@tannewt tannewt requested a review from jepler December 12, 2022 19:22
@dhalbert
Copy link
Collaborator

This didn't seem to be necessary after some recent merges, so it may depend on how many commits back various things are. I will mark this as 8.x.x for now.

@dhalbert dhalbert added this to the 8.x.x milestone Dec 16, 2022
@jepler
Copy link
Member

jepler commented Jan 3, 2023

Closing this since the builds are working for now, and a potential longer term solution is to use partial clones. However, we can re-open this if we encounter the weird fetch errors again. Would rather not downgrade, as using old actions is not a long term solution (github loves to deprecate things used in actions)

@jepler jepler closed this Jan 3, 2023
@microdev1
Copy link
Collaborator Author

PR #7329 locked tj-actions/changed-files@v34.5.3, this version has a bug necessitating fetch-depth: 0 to work.
Re-opening this to test if @v34 works.

@microdev1 microdev1 reopened this Jan 5, 2023
@microdev1 microdev1 changed the title Downgrade tj-actions & Revert fetch-depth change Update tj-actions & Revert fetch-depth change Jan 5, 2023
tannewt
tannewt approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it worked! Let's try it. Thank you!

@tannewt tannewt merged commit 6013cde into adafruit:main Jan 5, 2023
@microdev1 microdev1 deleted the ci branch January 5, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

@jepler jepler Awaiting requested review from jepler

Assignees
No one assigned
Labels
bug tooling
Projects
None yet
Milestone
8.x.x
Development

Successfully merging this pull request may close these issues.

CI builds failing in tj-actions/changed-files
4 participants
@microdev1 @dhalbert @jepler @tannewt