redo pin never resetting for mimxrt10xx #7345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RetiredWizard let us know if this build works for you |
|
I also only have the teensy41 to test on but this PR did result in a build that boots on my teensy41. I ran my standard tests and everything seems to work fine. |
|
Reviewers might note that the forbidden pin checking is O(num_special_pins*num_all_pins) when resetting all pins. That's not ideal, but I think it's not really a problem. I was aware of this: I haven't yet figured out a clean way to make a compile-time boolean bit-mask table with pin numbers > 64, as I did for Espressif. |
tannewt
requested changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7312.
Redo pin resetting logic to never ever reset vital pins. Thanks to @RetiredWizard for diagnosis.
The only board I had to test is the Teensy 4.1, which does come up in the REPL. I did make it blink
board.LED.