Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed typo (path) in postCreateCommand #7350

Merged
merged 1 commit into from Dec 17, 2022
Merged

fixed typo (path) in postCreateCommand #7350

merged 1 commit into from Dec 17, 2022

Conversation

bablokb
Copy link

@bablokb bablokb commented Dec 16, 2022

fixes a typo in the path of the postCreateCommand

@bablokb
Copy link
Author

bablokb commented Dec 16, 2022

When I look at the failed checks, these are all architecture-builds which are not relevant for this pull-request.

Is there a way to configure the .devcontainer-subdirectory to prevent all these builds? This would save time and ressources.

@jepler
Copy link
Member

jepler commented Dec 16, 2022

the script ci_set_matrix.py in tools controls which boards are built based on the changed files. It has to be hand modified for exceptional files. It doesn't look like it has a facility right now to ignore whole directories, just individual files. So you could list your individual files, or you could add a facility to filter whole directories.

btw is there any possibility / utility to testing .devcontainer during our build? If a typo goes unnoticed, that's not great. If we could have found the problem automatically at CI time, that would have been better.

@bablokb
Copy link
Author

bablokb commented Dec 16, 2022

There is the possibility to pre-build containers. But I'm not sure that this catches problems with the postCreateCommand. And I think pre-build containers are not suitable for CircuitPython-builds, because I think it is important to do the whole fetch-submodule logic every time after a fresh-clone.

I will try to find something useful in the Github-docs.

BTW: this error prevented the postCreateCommand to run at all, but there could be errors in the script as well. Or the script is outdated because something changes in the build-environment. So the question here is if it is possible to reuse (parts of) your CI-pipeline.

@tannewt tannewt requested a review from jepler December 16, 2022 16:13
@bablokb
Copy link
Author

bablokb commented Dec 16, 2022

I checked pre-build containers, but they don't execute the postCreateCommand at all.

Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can merge this as-is, or I can wait for you to make the change to the script so updates to this file don't cause excess builds; ping me and let me know.

@bablokb
Copy link
Author

bablokb commented Dec 17, 2022

I'll make a pull request for the script, but that won't be before Wednesday.

@jepler jepler merged commit 37a3059 into adafruit:main Dec 17, 2022
@bablokb bablokb deleted the fix-devcontainer branch December 19, 2022 17:48
@bablokb bablokb mentioned this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants