Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pins.c for lolin_c3_mini #7392

Merged
merged 1 commit into from Dec 30, 2022
Merged

Update pins.c for lolin_c3_mini #7392

merged 1 commit into from Dec 30, 2022

Conversation

chukwon
Copy link

@chukwon chukwon commented Dec 28, 2022

also match lolin_c3_mini pins definition of new version

also match lolin_c3_mini pins definition of new version
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is OK, but might you want to define a new board for the old and the new versions of the board? For instance, trying to blink board.LED in a simple way is going to fail on the NeoPixel version of the board.

@dhalbert dhalbert merged commit ed5d9ac into adafruit:main Dec 30, 2022
@evildave666
Copy link

Since the v1.0 version of the board is depricated due to flaws in the antenna design and the board is already changed to match the v2.1 version, I'll take on making a new v1 board definition but may not get to it until after the holidays. circuitpython-org entry for the now-v2.1 board will need some edits removing the caveats regarding the antenna design flaw.

@dhalbert
Copy link
Collaborator

I'm thinking that if the v1.0 board is deprecated, a new board def may not really be needed. Instead, it could all be documented in the circuitpython.org description.

@dglaude
Copy link

dglaude commented Jan 1, 2023

I wonder what is the behaviour change on the V1 / V2.1 board.
I guess it is mostly the boot blinking vs colour that is affected.

So we have LED and NEOPIXEL alias, but if the goal is to focus on V2.1 then maybe LED can be removed.
That would make it perfect for V2.1 and V1 user just need to know that they can use NEOPIXEL to talk to their LED.

PS: I acquired both, but I will use the v1 for a non wifi and Arduino usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants