Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Watch for ctrl-c over BLE workflow serial #7465

Merged
merged 2 commits into from Jan 19, 2023
Merged

Watch for ctrl-c over BLE workflow serial #7465

merged 2 commits into from Jan 19, 2023

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Jan 19, 2023

Before this, it was impossible to interrupt a running program over BLE.

@tannewt
Watch for ctrl-c over BLE workflow serial
dca66eb 
Before this, it was impossible to interrupt a running program over
BLE.
@tannewt tannewt requested a review from dhalbert January 19, 2023 00:41
dhalbert
dhalbert requested changes Jan 19, 2023
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for a missing line, I think, in the espressif impl.

ports/espressif/common-hal/_bleio/CharacteristicBuffer.c Show resolved Hide resolved
@tannewt tannewt requested a review from dhalbert January 19, 2023 18:29
dhalbert
dhalbert approved these changes Jan 19, 2023
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks -- very important addition.

@dhalbert
Copy link
Collaborator

Re-running CI failed jobs before merging...

@dhalbert dhalbert merged commit 28afed9 into adafruit:main Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
ble workflow bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tannewt @dhalbert