Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for microcontroller.on_next_reset() on NRF #7468

Merged
merged 1 commit into from Jan 20, 2023
Merged

Fixes for microcontroller.on_next_reset() on NRF #7468

merged 1 commit into from Jan 20, 2023

Conversation

DavePutz
Copy link
Collaborator

@DavePutz DavePutz commented Jan 19, 2023 •
edited by dhalbert

This patch fixes two issues relating to microcontroller.on_next_reset() on NRF boards.

  1. Fixes microcontroller.on_next_reset() behavior discrepancy on nrf #5353. Using the SDK function sd_power_gpregret_set() instead of directly setting NRF_POWER->GPREGRET eliminates
    the problem of immediately resetting the board.
  2. Fixes CP resets to safe mode on calling microcontroller.on_next_reset(microcontroller.RunMode.UF2) #6975. Adding a test for a runmode of RUNMODE_UF2 in addition to RUNMODE_BOOTLOADER avoids the system firmware failure assertion.

dhalbert
dhalbert approved these changes Jan 20, 2023
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dhalbert dhalbert merged commit f826904 into adafruit:main Jan 20, 2023
@DavePutz DavePutz deleted the issue_6975 branch February 3, 2023 17:13
This was referenced Mar 31, 2023
Closed
Closed
@rdoursenaud
Copy link

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@DavePutz @rdoursenaud @dhalbert