Feather ESP32-S2 Reverse TFT: Update PID to match internal list #7478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jepler
changed the title
jepler
changed the title
|
yes! |
|
@jepler I'm confused, now there is a dupe between: |
|
adafruit_feather_esp32s2_tftback_nopsram was never/will never be made |
|
@dhalbert should we remove the other board definition (it's been there for quite awhile!) or permit the duplicate ID? |
|
Let's remove |
jepler
added a commit
to jepler/circuitpython-org
that referenced
this pull request
Jan 25, 2023
dhalbert
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ladyada please check this and leave a review so it's right this time :)