Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pewpew m4: enable CDC back #7501

Merged
merged 1 commit into from Jan 28, 2023
Merged

pewpew m4: enable CDC back #7501

merged 1 commit into from Jan 28, 2023

Conversation

deshipu
Copy link

@deshipu deshipu commented Jan 28, 2023

CDC got disabled on this board by mistake

@deshipu
Copy link
Author

deshipu commented Jan 28, 2023

This should fix #7498 7498

@dhalbert
Copy link
Collaborator

dhalbert commented Jan 28, 2023

@deshipu Now some languages don't quite fit. These are the included modules from the last RTD build:

_stage, analogio, array, audiocore, audioio, audiomixer, board, builtins, busio, collections,
digitalio, displayio, fontio, keypad, math, microcontroller, nvm, os, random, storage, struct,
supervisor, synthio, sys, terminalio, time, watchdog, zlib

Frozen Modules: pew, stage, ugame

There are some specialized disablers you could use:

CIRCUITPY_BUSIO_SPI = 0         no busio.SPI
CIRCUITPY_BUSIO_UART = 0     no busio.UART

Also this can squeeze some space, at the expense of some performance of the VM

CIRCUITPY_COMPUTED_GOTO_SAVE_SPACE = 1

@FoamyGuy
Copy link
Collaborator

We could try disabling zlib with CIRCUITPY_ZLIB = 0 instead of current 1.

I didn't check all the languages, but did try a few and got successful builds from this branch with the change to disable zlib.

@deshipu
Copy link
Author

deshipu commented Jan 28, 2023

@FoamyGuy I need zlib to decode png images.
@dhalbert I think we can disable analogio, I will update the PR.

CDC got disabled on this board by mistake
@deshipu
Copy link
Author

deshipu commented Jan 28, 2023

Also disabled watchdog

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick work on this. It will be in rc.0.

@dhalbert dhalbert merged commit 7522522 into adafruit:main Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants