Fix print of "soft reboot" when the user presses ^D #7652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic of the main loop was changed between version 7 and 8. [Commit](9307b62) Something is wrong with the existing version 8 logic so the serial write of "soft reboot" is never executed when the user does a soft reboot. A consequence of this is that tools like `tools/pyboard.py`, `ampy` and `mpremote` are not able to activate the raw REPL since they execute a soft reboot and wait for this to be printed to the console.
dhalbert
requested changes
Feb 27, 2023
dhalbert
approved these changes
Feb 27, 2023
|
Shoot. I may have screwed that up by checking the "Copy the main branch only" checkbox when I created my CircuitPython fork. So I don't have the 8.0.x branch. I've been looking but I can't find how to add this branch to my fork after the fact. Do you know? |
|
I have found this more difficult recently, not sure why. |
dhalbert
added a commit
to dhalbert/circuitpython
that referenced
this pull request
Feb 27, 2023
Fix print of "soft reboot" when the user presses ^D
dhalbert
added a commit
to dhalbert/circuitpython
that referenced
this pull request
Feb 27, 2023
Fix print of "soft reboot" when the user presses ^D
dhalbert
added a commit
that referenced
this pull request
Feb 28, 2023
8.0.x Backport of #7652 ("soft reboot" printing); update frozen libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic of the main loop was changed between version 7 and 8 (Commit). Something is wrong with the existing version 8 logic so the serial write of "soft reboot" is never executed when the user does a soft reboot.
A consequence of this is that tools like
tools/pyboard.py,ampyandmpremoteare not able to activate the raw REPL since they execute a soft reboot and wait for this to be printed to the console.