Add Adafruit Feather RP2040 Prop-Maker #7877
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ladyada
Board name
Name is "Prop-Maker", with a hyphen, to match the FeatherWing name; not "PropMaker", and not "Prop Maker".
Pin names
Board-specific pin names were a bit tricky to decide on. Let me know if you have other ideas.
I2S pins
I2S pins match the argument names for the constructor:
board.I2S.BIT_CLOCK
board.I2S_DATA
board.I2S_WORD_SELECT
Button pin
The button terminal is called
EXTERNAL_BUTTON
to distinguish it from the on-boardboard.BUTTON
, which is the name it has on the other similar RP2040 Feathers. I decided againstBUTTON2
or similar.EXTERNAL_BUTTON
is unambiguous.board.EXTERNAL_BUTTON
NeoPixel strip control
As with the external button, calling them
EXTERNAL_NEOPIXELS
andEXTERNAL_NEOPIXELS_POWER
makes them unambiguous, and clearly separate from the on-boardboard.NEOPIXEL
. It looks to me like thePOWER
control is active high. If not, let me know and I'll add_INVERTED
.board.EXTERNAL_NEOPIXELS
board.EXTERNAL_NEOPIXELS_POWER
Servo
Not
EXTERNAL_SERVO
, because there is no onboard servo :)board.SERVO
Accelerometer
board.ACCELEROMETER_INTERRUPT