Add address_little_endian and fix display memory reuse #7891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add address_little_endian for epaper displays with little endian (low byte first) addresses. Also clears allocated display and display bus memory so it has a known state. The acep member wasn't always set so it varied accidentally. Fixes micropython#7560. May fix micropython#7778. Fixes micropython#5119.
dhalbert
requested changes
Apr 24, 2023
There was a problem hiding this comment.
I did not see any code issues, but I smoke-tested this on a PYPortal, CLUE, MONSTER M4SK, and a Macropad (I2C display). All but the Macropad were fine. On the Macropad, there is some kind of rolling/flickering effect. The first time I loaded it, the screen was unreadable. The second time, I could see the REPL, but there was a rolling effect down from the top.
|
Thanks for the testing! I didn't fully move Display over to the core attributes. Fixed now. |
This was referenced Apr 25, 2023
dhalbert
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add address_little_endian for epaper displays with little endian
(low byte first) addresses.
Also clears allocated display and display bus memory so it has a
known state. The acep member wasn't always set so it varied
accidentally.
Fixes #7560. May fix #7778. Fixes #5119.