Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix creating virtual environment for stub creation #7934

Merged
merged 1 commit into from
May 5, 2023

Conversation

tekktrik
Copy link
Member

@tekktrik tekktrik commented May 4, 2023

Fixes a small bug I noticed

@tekktrik
Copy link
Member Author

tekktrik commented May 4, 2023

I did not realize a space was not needed!

@tekktrik tekktrik closed this May 4, 2023
@jepler
Copy link
Member

jepler commented May 4, 2023

If the latter form is more standard and creates less confusion, we should change it

@tekktrik tekktrik reopened this May 5, 2023
@tekktrik
Copy link
Member Author

tekktrik commented May 5, 2023

Okay, I just reopened it then. I do typically see -m venv-name as opposed to -mvenv-name, and our own library instructions use that first form.

Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! it works either way, but "-m venv" is more standard and clearer.

@jepler jepler merged commit 5c85720 into adafruit:main May 5, 2023
426 of 830 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants