-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Access Point static IPv4 on the espressif port #7946
Conversation
looks like it's applying a new formatting rule to old code, do I edit the old code? |
several languages not building on PicoW variants edit: oh, I guess I need to stub out the PicoW common-hal or do Not Implemented exceptions or something... |
This is ready to go. I'll try PicoW as a separate PR after this one is merged since: I don't know much about those internals; I haven't set up to build raspberrypi yet, and; PicoW wifi can be quirky. I looked at the code and I think I know what needs to be done, but if there are challenges with a straight-forward implementation modeled after station, then outcome is uncertain. If someone else wants to do PicoW, that's fine too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Do you think we should split this in 9.0 into two objects? One for station and one for ap.
The properties and methods keep growing, and we've known for some time that the naming can be confusing (e.g., The ability to enable and disable wifi completely independently from starting or stopping station or AP can be pretty powerful (current CYW43 limitations aside), I don't think we want to mess that up. Maybe an issue for discussion is a good place to start. |
Relevant to Issue #7931
AP:
Station (separate device):
Tested by connecting to the AP from another CircuitPython device and from a desktop computer. Also ran a TCP echo server on the circuitpython AP, and sent packets to it from the circuitpython TCP station and from a desktop Python TCP client.
Note that connecting stations will be assigned IP addresses sequentially starting with the AP static IPv4 + 1.