Synthio: next round of features #7959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bend can be static, sweep, or vibrato
A note can be placed in the center (panning=0) or moved to just the left (panning=1) or right (panning=-1) channels. Fractional panning values place it partially in both channels.
When there's no sustain, the release step needs to be calculated from the attack level, not the sustain level. Otherwise, contrary to intent, this leads to the actual release taking a loooonnngg time.
tannewt
requested changes
May 11, 2023
as step 1/n of adding FIR filtering
A 37-tap filter worked fine on RP2040 (prop maker) at 48kHz, so you can probably pretty much go nuts on M7.
jepler
force-pushed
the
synthio-bend-pan-ring
branch
from
daeff07
to
bc7feb3
Compare
The accumulator saturate logic was wrong, and the sweep was never restarted either
tannewt
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
synthio.Synthesizermay be constructed withchannel_count=2. Thesynthio.Note.panningproperty controls whether it appears in the left, right, or both channels.twoadditional modes: Sweep out, sweep in, and bend.vibrato_rateandvibrato_depthproperties are removed, with newbend_rate,bend_depthandbend_modeproperties added. The defaultbend_modeisVIBRATO, so migrate existing code just by search&replace.SWEEPdoes a sweep up or down starting from the note's base frequency. ``SWEEP_OUTdoes a sweep that ends at the note's base frequency. STATICjust lets the value be set dynamically from python code.ring_waveform, then this waveform is used (atring_frequency) to modulate the main note waveform.give BendMode.STATIC a better namenaming things is hard[added, not tested]