Do not enable web_workflow background callbacks if wifi is not enabled/connected #7960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll look once CI is green. |
|
Whoops - sorry about that. All fixed now - just Wifi boards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Web Workflow startup is called from
supervisor_workflow_resetwhich is invoked at every VM start/exit. Actual startup is not called until after safemode run has been attempted. Attempting to handle workflow background callbacks without having wifi connected references un-initialized socket objects which can cause corruption or crashes. This patch prevents thesupervisor_web_workflow_backgroundfrom being invoked if web workflow wifi is not connected.