Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adafruit_bus_device SPIDevice can have None for chip select #7970

Merged
merged 1 commit into from
May 12, 2023
Merged

adafruit_bus_device SPIDevice can have None for chip select #7970

merged 1 commit into from
May 12, 2023

Conversation

dhalbert
Copy link
Collaborator

The native version of adafruit_bus_device.spi_device.SPIDevice did not allow chip_select to be None. The CircuitPython library did allow this. Also it would have not allowed passing None explicitly. Fixed those things, and also fixed documentation.

@dhalbert dhalbert requested review from tannewt and jepler May 12, 2023 19:32
tannewt
tannewt approved these changes May 12, 2023
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit 40f1ac1 into adafruit:main May 12, 2023
340 checks passed
@dhalbert dhalbert deleted the adafruit_bus_device-no-cs branch May 12, 2023 22:43
@dearmash
Copy link

Many thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

@jepler jepler Awaiting requested review from jepler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chip select should be allowed to be null
3 participants
@dhalbert @dearmash @tannewt