Await CYW43_LINK_DOWN in stop_station
#7982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anecdata
previously approved these changes
May 15, 2023
There was a problem hiding this comment.
Before this PR:
wifi.radio.start_ap() will fail with
RuntimeError: Wifi is in station mode.if it immediately followswifi.radio.stop_station().about 10% of the time.
(re-verified the issue using current build)
With this PR:
Adafruit CircuitPython 8.1.0-beta.2-32-g3ff7fa5d8 on 2023-05-15; Raspberry Pi Pico W with rp2040
Example code from the issue has been running successfully for >500 iterations. LGTM, thanks!
dhalbert
requested changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It exits seeminly immediately, but should fix #7906.
@anecdata Please test it in your application.