Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fetch-submodules.sh for older git #8073

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

dhalbert
Copy link
Collaborator

@dhalbert dhalbert commented Jun 7, 2023

#8070 did not work properly with older versions of git that could not do partial clones (before git 2.36). I tested this with git 2.30.1 on several ports, starting with no submodules each time. I was able to simplify the older shallow-depth commands a bit.

Thanks @jposada202020 who found the initial problem.

If you has an older version of git (before 2.36) and are interested in testing, you could try this. The simplest way is probably just replacing tools/fetch-submodules.sh from main with the new version here.

@RetiredWizard
Copy link

I'm running ubuntu 22.04 & git 2.34.1. I was seeing the issue reported by @jposada202020 but after replacing tools/fetch-submodules.sh with this version I've run the new fetch-port-submodules and built a board on atmel-samd, broadcom, espressif, mimxrt10xx, nrf, raspberrypi, silabs and stm without any issue.

Copy link
Collaborator

@jposada202020 jposada202020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Two Tests:

  1. Machine test ubuntu 22.04 with Git 2.40.1 ---- Worked fetching port submodules
  2. Machine test ubuntu 22.04 with git 2.34.1 --- Worked fetching port submodules

Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on others testing

@dhalbert dhalbert merged commit f2c38e0 into adafruit:main Jun 7, 2023
421 checks passed
@dhalbert dhalbert deleted the submodules-with-older-git branch June 7, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants