Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Esp32 AnalogIn IO32 fix #8607

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Esp32 AnalogIn IO32 fix #8607

merged 1 commit into from
Nov 16, 2023

Conversation

dhalbert
Copy link
Collaborator

@dhalbert dhalbert commented Nov 15, 2023 •
edited

Fixes #8313.

  • Fix ADC channel for IO32.
  • Use better constant names when checking pin validity.

Tested on a Feather HUZZAH32 breakout with a potentiometer and connecting to GND and 3.3V. Tested pins IO32, IO33, and IO35.

@dhalbert dhalbert linked an issue Nov 15, 2023 that may be closed by this pull request
ESP32: ADC1 pins always read the same value #8313
Closed
tannewt
tannewt approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit 269f352 into adafruit:8.2.x Nov 16, 2023
148 checks passed
@dhalbert dhalbert deleted the esp32-analogin branch December 23, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

@jepler jepler Awaiting requested review from jepler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ESP32: ADC1 pins always read the same value
2 participants
@dhalbert @tannewt